docker-compose.prod.yml contains unused nginx/certbot services and conflicting VITE env #40

New issue

Closed

opened 2026-08-23 05:42:06 +00:00 by nasandre · 2 comments

nasandre commented

2026-08-23 05:42:06 +00:00

Owner

Cleanup

nginx + certbot services are dead config: production TLS is handled by Caddy (routes /api→8873, /mcp→8874, rest→8872). No nginx container is running, yet compose still defines `nginx` and `certbot` services referencing `./nginx-prod.conf` and SSL dirs. Confusing and risks someone starting a conflicting proxy on :80/:443.
VITE_API_URL defined twice with different values for frontend: build arg `https://roguetrader.tabletopamsterdam.nl/api` vs runtime env `http://backend:3001`. Vite bakes env at build time — runtime value is misleading dead weight.

Suggested fix

Remove nginx/certbot services (or move to a clearly-named legacy file) and drop the runtime VITE_* env block from frontend.

## Cleanup 1. **nginx + certbot services are dead config**: production TLS is handled by Caddy (routes /api→8873, /mcp→8874, rest→8872). No nginx container is running, yet compose still defines \`nginx\` and \`certbot\` services referencing \`./nginx-prod.conf\` and SSL dirs. Confusing and risks someone starting a conflicting proxy on :80/:443. 2. **VITE_API_URL defined twice with different values** for frontend: build arg \`https://roguetrader.tabletopamsterdam.nl/api\` vs runtime env \`http://backend:3001\`. Vite bakes env at build time — runtime value is misleading dead weight. ## Suggested fix Remove nginx/certbot services (or move to a clearly-named legacy file) and drop the runtime VITE_* env block from frontend.

nasandre added the

Chore

label

2026-08-23 05:42:06 +00:00

nasandre commented

2026-08-23 06:18:50 +00:00

Author

Owner

✅ Fixed in docker-compose.prod.yml:

Removed unused nginx + certbot services (TLS is handled by Caddy)
Removed misleading runtime VITE_API_URL/VITE_MCP_URL env from frontend (Vite bakes env at build time via build args)

✅ **Fixed** in docker-compose.prod.yml: - Removed unused nginx + certbot services (TLS is handled by Caddy) - Removed misleading runtime VITE_API_URL/VITE_MCP_URL env from frontend (Vite bakes env at build time via build args)

nasandre referenced this issue from a commit

2026-08-23 06:55:48 +00:00

Fix issues #30-#40: security hardening, edit mode, mobile nav, transactions

nasandre commented

2026-08-23 06:56:43 +00:00

Author

Owner

✅ Fixed (commit 05b5453) — removed nginx + certbot services and the conflicting runtime VITE_* env block from docker-compose.prod.yml. Compose now only defines backend / mcp-server / frontend. Full stack redeployed cleanly with the new file.

✅ **Fixed** (commit `05b5453`) — removed nginx + certbot services and the conflicting runtime VITE_* env block from docker-compose.prod.yml. Compose now only defines backend / mcp-server / frontend. Full stack redeployed cleanly with the new file.

nasandre closed this issue

2026-08-23 06:56:43 +00:00

nasandre referenced this issue

2026-08-23 07:28:33 +00:00

[Chore] Remove committed backup and stale config files #8

nasandre referenced this issue

2026-08-23 07:49:44 +00:00

[Chore] Remove committed backup and stale config files #8