MCP roll_characteristics uses different dice rules than the app (2d10+20 vs 2d10+25) #33

New issue

Closed

opened 2026-08-23 05:42:04 +00:00 by nasandre · 1 comment

nasandre commented

2026-08-23 05:42:04 +00:00

Owner

Medium

Two different characteristic-generation rules are implemented:

Frontend creation page rolls 2d10+25 (range 27–45): `CharacterCreationPage.tsx:237-241`
MCP tool returns 2d10+20 (range 22–40): `mcp-server/server.py:288-299`

Whichever is canonical per the CRPG rules, one of them is wrong; results differ depending on which path generated the character.

Suggested fix

Pick the correct formula (CRPG uses 2d10+25), move it to a shared constant, and use it in both places.

## Medium Two different characteristic-generation rules are implemented: - Frontend creation page rolls **2d10+25** (range 27–45): \`CharacterCreationPage.tsx:237-241\` - MCP tool returns **2d10+20** (range 22–40): \`mcp-server/server.py:288-299\` Whichever is canonical per the CRPG rules, one of them is wrong; results differ depending on which path generated the character. ## Suggested fix Pick the correct formula (CRPG uses 2d10+25), move it to a shared constant, and use it in both places.

nasandre added the

Bug

label

2026-08-23 05:42:04 +00:00

nasandre commented

2026-08-23 06:18:49 +00:00

Author

Owner

✅ Fixed in mcp-server/server.py: roll_characteristics now uses 2d10+25 (range 27–45), matching the frontend creation page.

✅ **Fixed** in mcp-server/server.py: roll_characteristics now uses 2d10+25 (range 27–45), matching the frontend creation page.

nasandre referenced this issue from a commit

2026-08-23 06:55:48 +00:00